Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(bindings/nodejs): Add more APIs and examples #1799

Merged
merged 5 commits into from
Mar 30, 2023
Merged

feat(bindings/nodejs): Add more APIs and examples #1799

merged 5 commits into from
Mar 30, 2023

Conversation

suyanhanx
Copy link
Member

@suyanhanx suyanhanx commented Mar 30, 2023 •
edited
Loading

Add APIs

  • check
  • isExist
  • remove
  • removeAll

@suyanhanx
feat(bindings/nodejs): Add more APIs and examples
05ee6f7 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
reformat
a7b7bb6 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@Xuanwo
Copy link
Member

Xuanwo commented Mar 30, 2023

Maybe we can remove the example file in this PR?

@suyanhanx
Copy link
Member Author

Maybe we can remove the example file in this PR?

Right.

@suyanhanx
chore: upgrade typedoc to support TypeScript 5
e59be9d 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
remove example
6e3f5d6 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
simplify presign docs
0c75c26 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Xuanwo
Xuanwo approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice! Thanks a lot!

@Xuanwo Xuanwo merged commit f199ca0 into apache:main Mar 30, 2023
@suyanhanx suyanhanx deleted the sync-more-api branch March 30, 2023 04:38
@Xuanwo Xuanwo mentioned this pull request Mar 30, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suyanhanx @Xuanwo