Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(bindings/nodejs): Fix generated headers #1802

Merged
merged 3 commits into from
Mar 30, 2023
Merged

chore(bindings/nodejs): Fix generated headers #1802

merged 3 commits into from
Mar 30, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Mar 30, 2023

No description provided.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from suyanhanx March 30, 2023 07:48
Signed-off-by: Xuanwo <github@xuanwo.io>
@suyanhanx
Copy link
Member

Let me have a try.

@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 30, 2023

Let me have a try.

Welcome for better solution!

Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.

Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Xuanwo Xuanwo merged commit 3488ec3 into main Mar 30, 2023
@Xuanwo Xuanwo deleted the fix-header branch March 30, 2023 08:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants