refactor: Change presign to async for future refactor #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
requested review from
suyanhanx,
PsiACE,
ClSlaid and
sundy-li
as code owners
Signed-off-by: Xuanwo <github@xuanwo.io>
ClSlaid
approved these changes
Apr 11, 2023
wcy-fdu
pushed a commit
to wcy-fdu/opendal
that referenced
this pull request
Apr 12, 2023
* refactor: Change presign to async for future refactor Signed-off-by: Xuanwo <github@xuanwo.io> * Fix unit test Signed-off-by: Xuanwo <github@xuanwo.io> --------- Signed-off-by: Xuanwo <github@xuanwo.io>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future:
reqsignwill be asyncblocking_presign