Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ci(bindings/nodejs): Access should be set to public before publish #1919

Merged
merged 2 commits into from
Apr 12, 2023
Merged

ci(bindings/nodejs): Access should be set to public before publish #1919

merged 2 commits into from
Apr 12, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 12, 2023

No description provided.

@Xuanwo Xuanwo requested a review from suyanhanx April 12, 2023 04:12
@suyanhanx
Copy link
Member

suyanhanx commented Apr 12, 2023 •
edited
Loading

We may use npm publish --access public

https://docs.npmjs.com/configuring-your-npm-client-with-your-organization-settings#changing-default-package-visibility-to-public

My mistake for removing it.

@Xuanwo
Update
c6b1abf 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 12, 2023

My mistake for removing it.

npm sucks.

@Xuanwo Xuanwo merged commit 86faaa4 into main Apr 12, 2023
@Xuanwo Xuanwo deleted the fix-nodejs branch April 12, 2023 04:24
suyanhanx
suyanhanx approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

wcy-fdu pushed a commit to wcy-fdu/opendal that referenced this pull request Apr 12, 2023
@Xuanwo @wcy-fdu
ci(bindings/nodejs): Access should be set to public before publish (a…
caabae2 
…pache#1919)

* ci(bindings/nodejs): Access should be set to public before publish

Signed-off-by: Xuanwo <github@xuanwo.io>

* Update

Signed-off-by: Xuanwo <github@xuanwo.io>

---------

Signed-off-by: Xuanwo <github@xuanwo.io>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@ClSlaid ClSlaid ClSlaid approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xuanwo @suyanhanx @ClSlaid