Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(layer): add madsim layer #2006

Merged
merged 20 commits into from
Apr 18, 2023
Merged

feat(layer): add madsim layer #2006

merged 20 commits into from
Apr 18, 2023

Conversation

SkyFan2002
Copy link
Contributor

@SkyFan2002 SkyFan2002 commented Apr 15, 2023 •
edited by Xuanwo
Loading

Fix #1871

Xuanwo
Xuanwo reviewed Apr 15, 2023
View reviewed changes
@Xuanwo
Copy link
Member

Xuanwo commented Apr 15, 2023

Hi @wangrunji0408, could you please take a look when you have some free time? Thank you in advance.

Xuanwo
Xuanwo reviewed Apr 15, 2023
View reviewed changes
@Xuanwo Xuanwo mentioned this pull request Apr 15, 2023
Open
@Xuanwo Xuanwo marked this pull request as draft April 16, 2023 00:46
@SkyFan2002 SkyFan2002 marked this pull request as ready for review April 17, 2023 14:59
Xuanwo
Xuanwo reviewed Apr 17, 2023
View reviewed changes
@Xuanwo
Copy link
Member

Xuanwo commented Apr 17, 2023

Please update with main branch to avoid possible conflicts.

wangrunji0408
wangrunji0408 reviewed Apr 18, 2023
View reviewed changes
Copy link

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see the effort to integrate madsim. Good work!

@SkyFan2002 SkyFan2002 force-pushed the madsim_layer_archive branch from 6464e77 to 7472d86 Compare April 18, 2023 06:44
Xuanwo
Xuanwo reviewed Apr 18, 2023
View reviewed changes
@SkyFan2002 SkyFan2002 force-pushed the madsim_layer_archive branch from 6a4fa82 to 0ca264d Compare April 18, 2023 08:08
@SkyFan2002 SkyFan2002 force-pushed the madsim_layer_archive branch from e6bdcbb to 01a3ca8 Compare April 18, 2023 08:10
Xuanwo
Xuanwo reviewed Apr 18, 2023
View reviewed changes
@SkyFan2002 SkyFan2002 force-pushed the madsim_layer_archive branch from 81f1108 to f3e9434 Compare April 18, 2023 08:43
Xuanwo
Xuanwo approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo
Copy link
Member

Xuanwo commented Apr 18, 2023

Let's integrate this layer for real use-cases and than improve it.

@Xuanwo Xuanwo merged commit 59c1cce into apache:main Apr 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wangrunji0408 wangrunji0408 wangrunji0408 left review comments

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

layers: madsim support
3 participants
@SkyFan2002 @Xuanwo @wangrunji0408