Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(core): add copy&rename to error_context layer #2040

Merged
merged 1 commit into from
Apr 19, 2023
Merged

feat(core): add copy&rename to error_context layer #2040

merged 1 commit into from
Apr 19, 2023

Conversation

suyanhanx
Copy link
Member

No description provided.

Xuanwo
Xuanwo requested changes Apr 19, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but bindings/c has been changed unintendedly. Maybe need to sync with main branch?

@suyanhanx
Copy link
Member Author

👀 It was changed when I run cargo clippy. Ummm...

@suyanhanx
feat(core): add copy&rename to error_context layer
705d761 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx force-pushed the add-copy-rename-error_context branch from cc930b9 to 705d761 Compare April 19, 2023 12:35
@suyanhanx suyanhanx marked this pull request as ready for review April 19, 2023 12:35
@suyanhanx
Copy link
Member Author

Mostly LGTM, but bindings/c has been changed unintendedly. Maybe need to sync with main branch?

Rollback done.

Xuanwo
Xuanwo approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 9a6d30f into main Apr 19, 2023
@Xuanwo Xuanwo deleted the add-copy-rename-error_context branch April 19, 2023 12:39
@Xuanwo Xuanwo mentioned this pull request Apr 23, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suyanhanx @Xuanwo