Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor(raw/http_util): Add url in error context #2066

Merged
merged 1 commit into from
Apr 22, 2023
Merged

refactor(raw/http_util): Add url in error context #2066

merged 1 commit into from
Apr 22, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 22, 2023

This PR will:

@Xuanwo
refactor(raw/http_util): Add url in error context
b313940 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from suyanhanx April 22, 2023 09:38
suyanhanx
suyanhanx approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM on ci green.

@Xuanwo Xuanwo merged commit 40a0d04 into main Apr 22, 2023
@Xuanwo Xuanwo deleted the refactor-request branch April 22, 2023 09:48
@Xuanwo Xuanwo mentioned this pull request Apr 23, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: also log endpoint URL when failure
2 participants
@Xuanwo @suyanhanx