Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(services/s3): Add start-after support for list #2096

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

lexcao
Copy link
Contributor

@lexcao lexcao commented Apr 23, 2023

Closes #2095

This PR introduces new features:

  1. add list_with_start_after capability
  2. add test_list_with_start_after test case

@lexcao lexcao force-pushed the add_start_after_for_s3 branch 2 times, most recently from 435df91 to 82f9de2 Compare April 24, 2023 15:53
Closes apache#2095
This PR introduces new features:
1. add `list_with_start_after` capability
2. add `test_list_with_start_after` test case
@lexcao lexcao force-pushed the add_start_after_for_s3 branch from 82f9de2 to 052aeba Compare April 24, 2023 15:59
@lexcao
Copy link
Contributor Author

lexcao commented Apr 24, 2023

Thanks @suyanhanx and @Xuanwo so much for your kindly suggestions.
These are really helpful and I have done all the changes.

Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Xuanwo Xuanwo merged commit de8a636 into apache:main Apr 24, 2023
@lexcao lexcao deleted the add_start_after_for_s3 branch April 24, 2023 16:06
@Xuanwo Xuanwo mentioned this pull request Apr 25, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add start-after support for s3
3 participants