Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: Bring hdfs test back #2114

Merged
merged 26 commits into from
Apr 25, 2023
Merged

ci: Bring hdfs test back #2114

merged 26 commits into from
Apr 25, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 25, 2023

No description provided.

Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo added 6 commits April 25, 2023 17:27
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@suyanhanx
Copy link
Member

Seems quite complicated.

@PsiACE
Copy link
Member

PsiACE commented Apr 25, 2023

Perhaps we can maintain a docker-compose file, webhdfs and hdfs both need to start a similar service.

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 25, 2023

Seems quite complicated.

This is hdfs.

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 25, 2023

Perhaps we can maintain a docker-compose file, webhdfs and hdfs both need to start a similar service.

hdfs is more complex because we need to run the test inside hdfs context.

Xuanwo added 5 commits April 25, 2023 18:12
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo added 5 commits April 25, 2023 18:35
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 25, 2023

HDFS test is running now! I will fix failed cases one by one.

Xuanwo added 4 commits April 25, 2023 19:39
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo added 5 commits April 25, 2023 21:16
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 25, 2023

All tests passed!

cc @suyanhanx & @PsiACE, PTAL.

@Xuanwo Xuanwo requested a review from suyanhanx April 25, 2023 14:06
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@PsiACE PsiACE merged commit 8fc4f89 into main Apr 25, 2023
@PsiACE PsiACE deleted the bring-hdfs-test-back branch April 25, 2023 14:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants