Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test(core): test for write_with_cache_control #2131

Merged
merged 13 commits into from
Apr 26, 2023

Conversation

suyanhanx
Copy link
Member

@suyanhanx suyanhanx commented Apr 26, 2023

part of #2060

@suyanhanx suyanhanx marked this pull request as ready for review April 26, 2023 07:18
@suyanhanx suyanhanx marked this pull request as draft April 26, 2023 07:49
@suyanhanx suyanhanx marked this pull request as ready for review April 26, 2023 08:03
@suyanhanx suyanhanx marked this pull request as draft April 26, 2023 08:32
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx force-pushed the test-for-override-cache-control branch from c85f081 to 986e38d Compare April 26, 2023 14:13
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx marked this pull request as ready for review April 26, 2023 15:39
@suyanhanx
Copy link
Member Author

gcs is acting so weird. 😵‍💫

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx marked this pull request as draft April 26, 2023 16:02
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx marked this pull request as ready for review April 26, 2023 16:27
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit 4f2fc2a into main Apr 26, 2023
@Xuanwo Xuanwo deleted the test-for-override-cache-control branch April 26, 2023 18:03
@Xuanwo Xuanwo mentioned this pull request Apr 27, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants