-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(services/gdrive): Add read & write & delete support for GoogleDrive #2184
Conversation
What do you think is the appropriate place to store the cache of |
A hashmap in core is good enough. |
I mean who own the hashmap. An intuitive idea is to make it a member of GoogleDriveBackend, but modifying this hashmap in get_file_id_by_path() requires |
An |
I'd like to left |
BTW, this branch seems contained not related commits. |
It's wired, it occurs after I resolved the conflicts. |
You can try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
#654