feat(services/sftp): Add read/write/stat support for sftp #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silver-ymz
requested review from
Xuanwo,
PsiACE,
ClSlaid and
sundy-li
as code owners
Xuanwo
reviewed
May 1, 2023
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impl #708
This PR adds support for the sftp backend using the openssh-sftp-client library.
Misc
In the
Connectionstruct, the sftp connection is stored while hiding thesessionandchannelused to create the connection. However, theChanneldefinition requires the 'sess lifetime in its type annotation, whileSessiondoes not. To address this, theOwningHandleis used to ensure thatChannelhas ownership ofSessionto pass the lifetime check. A similar situation exists forSftpReader.Tests
All tests have passed except for
test_list_rich_dir, which seems to be an upstream issue. The problem is that it misses some files when listing a folder with many files, and an issue has been opened for it at openssh-rust/openssh-sftp-client#62.