Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(services/vercel): Add vercel remote cache support #2193

Merged
merged 4 commits into from
May 2, 2023
Merged

feat(services/vercel): Add vercel remote cache support #2193

merged 4 commits into from
May 2, 2023

Conversation

Retrospection
Copy link
Contributor

close #2149

@Retrospection
Copy link
Contributor Author

Retrospection commented May 2, 2023 •
edited
Loading

TODO:

  • fix ci
  • do some local test
  • Improve comments

@Retrospection Retrospection force-pushed the main branch 3 times, most recently from 8cf8260 to fc62b4e Compare May 2, 2023 12:16
@Retrospection Retrospection marked this pull request as ready for review May 2, 2023 12:22
Xuanwo
Xuanwo reviewed May 2, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Here are some comments.

@Retrospection Retrospection force-pushed the main branch 2 times, most recently from 4f2ae15 to 3b45299 Compare May 2, 2023 14:58
@Retrospection
feat(services/vercel): Add vercel remote cache support
a94d6cc 
Signed-off-by: Retros <footsteprex@gmail.com>
Xuanwo
Xuanwo approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Retrospection
Copy link
Contributor Author

Great, thanks!

Thanks for your kind review~

Xuanwo added 3 commits May 3, 2023 01:00
@Xuanwo
chore
d2bb7b2 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Merge remote-tracking branch 'origin/main' into Retrospection/main
ee0694e
@Xuanwo
Don't enable not ready services as default
4715811 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit 9154410 into apache:main May 2, 2023
@Xuanwo Xuanwo mentioned this pull request May 6, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

services: Add support Vercel Remote Caching
2 participants
@Retrospection @Xuanwo