Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: Setup vercel artifacts integration tests #2197

Merged
merged 2 commits into from
May 2, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented May 2, 2023

This PR will help set up vercel artifacts integration tests.

Failed test cases are tracking in #2198, we can merge this PR first.

There are following tests still failed:

failures:
    services_vercelartifacts::write_test_create_dir
    services_vercelartifacts::write_test_create_dir_existing
    services_vercelartifacts::write_test_delete
    services_vercelartifacts::write_test_delete_empty_dir
    services_vercelartifacts::write_test_delete_not_existing
    services_vercelartifacts::write_test_delete_stream
    services_vercelartifacts::write_test_delete_with_special_chars
    services_vercelartifacts::write_test_fuzz_offset_reader
    services_vercelartifacts::write_test_fuzz_part_reader
    services_vercelartifacts::write_test_fuzz_range_reader
    services_vercelartifacts::write_test_read_full
    services_vercelartifacts::write_test_read_large_range
    services_vercelartifacts::write_test_read_range
    services_vercelartifacts::write_test_read_with_dir_path
    services_vercelartifacts::write_test_read_with_special_chars
    services_vercelartifacts::write_test_reader_from
    services_vercelartifacts::write_test_reader_range
    services_vercelartifacts::write_test_stat
    services_vercelartifacts::write_test_stat_dir
    services_vercelartifacts::write_test_stat_not_cleaned_path
    services_vercelartifacts::write_test_stat_not_exist
    services_vercelartifacts::write_test_stat_root
    services_vercelartifacts::write_test_stat_with_special_chars
    services_vercelartifacts::write_test_write
    services_vercelartifacts::write_test_write_with_special_chars

To address them, we should:

  • Implement stat/delete/create_dir
  • Some cases seems related to vercel's range support, we need more research:
[2023-05-02T17:42:43Z DEBUG behavior::utils] 299f30d9-f809-4a37-8f92-42e2193d09e7 perform fuzz action: Next
[2023-05-02T17:42:43Z DEBUG behavior::utils] 299f30d9-f809-4a37-8f92-42e2193d09e7 perform fuzz action: Read(39693)
[2023-05-02T17:42:43Z DEBUG behavior::utils] 299f30d9-f809-4a37-8f92-42e2193d09e7 perform fuzz action: Next
[2023-05-02T17:42:43Z DEBUG behavior::utils] 299f30d9-f809-4a37-8f92-42e2193d09e7 perform fuzz action: Next
[2023-05-02T17:42:43Z DEBUG behavior::utils] 299f30d9-f809-4a37-8f92-42e2193d09e7 perform fuzz action: Seek(End(-641647))
[2023-05-02T17:42:43Z DEBUG behavior::utils] 299f30d9-f809-4a37-8f92-42e2193d09e7 perform fuzz action: Seek(Start(1002031))
[2023-05-02T17:42:43Z DEBUG behavior::utils] 299f30d9-f809-4a37-8f92-42e2193d09e7 perform fuzz action: Next
[2023-05-02T17:42:43Z DEBUG rustls::conn] Sending warning alert CloseNotify
thread 'services_vercelartifacts::write_test_fuzz_offset_reader' panicked at 'assertion failed: `(left == right)`
  left: `"2010485b33902bd343ad7402b91a8c74ce384df587a71682745f4239e0398893"`,
 right: `"0b1819ed21e022a6657c5dc7edea166b50d0d13f31291c62dde9def6c4a1a6f1"`: check next failed: output bs is different with expected bs, actions: [Read(377685), Next, Seek(End(-3143164)), Next, Seek(End(-2273789)), Next, Read(39693), Next, Next, Seek(End(-641647)), Seek(Start(1002031)), Next]', core/tests/behavior/utils.rs:267:13
[2023-05-02T17:42:43Z DEBUG opendal::services] service=vercel_artifacts operation=read path=299f30d9-f809-4a37-8f92-42e2193d09e7 read=55148 -> data read finished
[2023-05-02T17:42:43Z DEBUG rustls::conn] Sending warning alert CloseNotify
test services_vercelartifacts::write_test_fuzz_offset_reader ... FAILED

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested review from PsiACE, ClSlaid and sundy-li as code owners May 2, 2023 17:43
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Xuanwo Xuanwo merged commit 1ace92e into main May 2, 2023
@Xuanwo Xuanwo deleted the setup-vercel-artifacts-tesrt branch May 2, 2023 18:20
@Xuanwo Xuanwo mentioned this pull request May 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants