Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(tests): Etag must be wrapped by " #2226

Merged
merged 3 commits into from
May 7, 2023
Merged

fix(tests): Etag must be wrapped by " #2226

merged 3 commits into from
May 7, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented May 7, 2023

R2 has strong requirement for Etag:

[2023-05-07T17:34:30Z ERROR opendal::services] service=s3 operation=read path=df189c54-4664-433d-9c85-ed8f830f55cf range=0- -> failed: Unexpected (permanent) at read => S3Error { code: "InvalidArgument", message: "Invalid Argument: If-Match each ETag must be surrounded by double quotes, got 'invalid_etag'.", resource: "", request_id: "" }
    
    Context:
        response: Parts { status: 400, version: HTTP/1.1, headers: {"date": "Sun, 07 May 2023 17:34:30 GMT", "content-type": "application/xml", "content-length": "203", "connection": "keep-alive", "server": "cloudflare", "cf-ray": "7c3b36ce3b1bc729-SEA"} }
        service: s3
        path: df189c54-4664-433d-9c85-ed8f830f55cf
        range: 0-

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested review from PsiACE, ClSlaid and sundy-li as code owners May 7, 2023 17:36
@Xuanwo Xuanwo requested a review from suyanhanx May 7, 2023 17:37
Xuanwo added 2 commits May 8, 2023 02:03
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit e4d453b into main May 7, 2023
@Xuanwo Xuanwo deleted the fix-r2-if-match branch May 7, 2023 18:17
suyanhanx pushed a commit to suyanhanx/opendal that referenced this pull request May 8, 2023
* fix(tests): Etag must be wrapped by `"`

Signed-off-by: Xuanwo <github@xuanwo.io>

* Fix retry

Signed-off-by: Xuanwo <github@xuanwo.io>

* Pick a smaller batch limit

Signed-off-by: Xuanwo <github@xuanwo.io>

---------

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo mentioned this pull request May 9, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants