Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Support using rustls for TLS #491

Merged
merged 5 commits into from
Aug 2, 2022
Merged

Conversation

sunng87
Copy link
Contributor

@sunng87 sunng87 commented Aug 1, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

This patch adds a feature flag rustls to use rustls instead of openssl as TLS implementation.

@sunng87 sunng87 changed the title Add feature to Rustls for TLS Add feature to use Rustls for TLS Aug 1, 2022
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This PR is excellent.

I left some comments on our public API, PTAL.

@Xuanwo Xuanwo changed the title Add feature to use Rustls for TLS feat: Support using rustls for TLS Aug 1, 2022
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Xuanwo Xuanwo merged commit 6484a97 into apache:main Aug 2, 2022
@sunng87
Copy link
Contributor Author

sunng87 commented Aug 2, 2022

@Xuanwo Thanks for merging! Could you please create a release for this?

@Xuanwo
Copy link
Member

Xuanwo commented Aug 2, 2022

@Xuanwo Thanks for merging! Could you please create a release for this?

Let's go!

@Xuanwo
Copy link
Member

Xuanwo commented Aug 2, 2022

Addressed in #497

@sunng87
Copy link
Contributor Author

sunng87 commented Aug 2, 2022 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants