refactor: more consistent C binding pattern #5162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
force-pushed
the
cbingen-inners
branch
from
57b170f to
452ab64
Compare
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
force-pushed
the
cbingen-inners
branch
from
452ab64 to
c1de660
Compare
yuchanns
reviewed
Oct 6, 2024
bindings/c/src/writer.rs
Outdated
| @@ -70,7 +72,7 @@ impl opendal_writer { | |||
| #[no_mangle] | |||
| pub unsafe extern "C" fn opendal_writer_free(ptr: *mut opendal_writer) { | |||
| if !ptr.is_null() { | |||
| let _ = (&*ptr).deref_mut().close(); | |||
| let _ = (*ptr).deref_mut().close(); | |||
| let _ = unsafe { Box::from_raw((*ptr).inner as *mut core::BlockingWriter) }; | |||
bindings/c/src/writer.rs
Outdated
| @@ -70,7 +72,7 @@ impl opendal_writer { | |||
| #[no_mangle] | |||
| pub unsafe extern "C" fn opendal_writer_free(ptr: *mut opendal_writer) { | |||
| if !ptr.is_null() { | |||
| let _ = (&*ptr).deref_mut().close(); | |||
| let _ = (*ptr).deref_mut().close(); | |||
| let _ = unsafe { Box::from_raw((*ptr).inner as *mut core::BlockingWriter) }; | |||
| let _ = unsafe { Box::from_raw(ptr) }; | |||
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
This reverts commit deccb8b.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows #5160