Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(core)!: Remove not used cap write_multi_align_size #5322

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Nov 14, 2024

Which issue does this PR close?

None

Rationale for this change

write_multi_align_size is designed solely for gcs, but it's now never been used.

What changes are included in this PR?

Remove write_multi_align_size from capability.

Are there any user-facing changes?

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo changed the title refactor(core): Remove not used cap write_multi_align_size refactor(core)!: Remove not used cap write_multi_align_size Nov 14, 2024
Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #5322 will degrade performances by 18.88%

Comparing remove-range-writer (d179ca9) with main (4dc0f15)

Summary

❌ 8 regressions
✅ 65 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main remove-range-writer Change
buffer 256 KiB * 32 chunk 154.4 ns 183.6 ns -15.89%
buffer 256 KiB * 4 chunk 125.3 ns 154.4 ns -18.88%
buffer 4.00 MiB * 32 chunk 125.3 ns 154.4 ns -18.88%
buffer 4.00 MiB * 4 chunk 125.3 ns 154.4 ns -18.88%
256 KiB * 1000k truncate 245.8 ns 275 ns -10.61%
256 KiB * 100k truncate 245.8 ns 275 ns -10.61%
256 KiB * 10k truncate 245.8 ns 275 ns -10.61%
256 KiB * 1k truncate 245.8 ns 275 ns -10.61%

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 14, 2024

Thank you @PsiACE for the review!

@Xuanwo Xuanwo merged commit 104727c into main Nov 14, 2024
274 checks passed
@Xuanwo Xuanwo deleted the remove-range-writer branch November 14, 2024 11:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants