Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(services/webhdfs): rename auth value #5342

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

notauserx
Copy link
Contributor

@notauserx notauserx commented Nov 18, 2024

Closes #5267.

Renames the auth value from "delegation_token" to "delegation" based on doc

@notauserx notauserx requested a review from Xuanwo as a code owner November 18, 2024 16:19
@notauserx notauserx changed the title fix auth value fix(services/webhdfs): rename auth value Nov 18, 2024
@Xuanwo
Copy link
Member

Xuanwo commented Nov 19, 2024

Thank you @notauserx for the fix. This fix is correct, and it's my fault for misunderstanding the previous issues.

The only thing left here is to run a cargo fmt. Would you like to do this?

@notauserx
Copy link
Contributor Author

@Xuanwo added changes from cargo fmt

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @notauserx for the fix, really love it.

@Xuanwo Xuanwo merged commit 53c7122 into apache:main Nov 19, 2024
90 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: WebHDFS's url parameter should be changed (delegation_token -> delegation)
2 participants