feat(core): add if-match to OpWrite
#5360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Nov 27, 2024
|
thanks for the review! would fix soon |
Xuanwo
reviewed
Nov 27, 2024
|
Seems ceph rados s3 doesn't support write_with_if_match. Let's add a new config for s3 called hdfs related error is not related to this PR. |
Frank-III
force-pushed
the
s3-if-match
branch
from
b3bf7de to
4f68e84
Compare
|
Thank you @Frank-III for working on this! I'm guessing most tests have passed now. Please try merge with main branch to addess the clippy warnings. |
Frank-III
force-pushed
the
s3-if-match
branch
from
4f68e84 to
d18ff96
Compare
Xuanwo
approved these changes
Dec 4, 2024
Thank you again for your patient guidance! 😊 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5359. similar to what has been done in #5305, please review the code🙏
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
Add
op.write_with(path, content).if_match("<etag>")