Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(services/s3): fix batch delete with version #5684

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

meteorgan
Copy link
Contributor

Which issue does this PR close?

None

Rationale for this change

In #5349, we didn't handle the return values of batch delete, which could cause multiple batch delete operations to fail.

What changes are included in this PR?

  1. fix batch delete with version
  2. add behavior tests for batch delete
  3. fix some typos

Are there any user-facing changes?

@meteorgan meteorgan marked this pull request as ready for review March 2, 2025 15:36
@meteorgan meteorgan requested a review from Xuanwo as a code owner March 2, 2025 15:36
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @meteorgan for fixing this!

@Xuanwo
Copy link
Member

Xuanwo commented Mar 3, 2025

Hi, @meteorgan, you are now an OpenDAL committer and can submit PRs directly from the remote apache repository. This allows all your commits to be tested against our real services.

@Xuanwo Xuanwo merged commit c3b1a92 into apache:main Mar 3, 2025
244 checks passed
@meteorgan meteorgan deleted the fix-s3-batch-delete branch March 3, 2025 09:16
@meteorgan
Copy link
Contributor Author

Hi, @meteorgan, you are now an OpenDAL committer and can submit PRs directly from the remote apache repository. This allows all your commits to be tested against our real services.

Got it. Thanks for the reminder.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants