fix(core): fix list with recursive when the object doesn't exist #5732
+63
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorgan
force-pushed
the
fix-lister-when-dir-not-exist
branch
2 times, most recently
from
ca15d6c to
61d8e92
Compare
meteorgan
force-pushed
the
fix-lister-when-dir-not-exist
branch
from
16bd0c6 to
2f08d15
Compare
meteorgan
force-pushed
the
fix-lister-when-dir-not-exist
branch
from
2f08d15 to
ffb37c6
Compare
meteorgan
commented
Mar 12, 2025
| let (_, l) = self.acc.list(de.path(), OpList::new()).await?; | ||
| self.active_lister.push((Some(de), l)); | ||
| let (_, mut l) = self.acc.list(de.path(), OpList::new()).await?; | ||
| if let Some(v) = l.next().await? { |
There was a problem hiding this comment.
Here's an interesting issue: since we include every directory that contain a subdirectory or file, if the underlying service doesn't return the directory itself in the list operation, we won't be able to detect it. I discovered this behavior in the webdav service.
There was a problem hiding this comment.
Listing an empty root path can cover this case, but we need clear the root path before testing it.
meteorgan
commented
Mar 12, 2025
| } | ||
| } else { | ||
| return Ok(Some(v)); | ||
| } |
There was a problem hiding this comment.
Generally, we could return Ok(None) immediately when detecting that a directory doesn't exist. However, if another thread is deleting content in related directories, we may return too early. The behavior tests caught this issue.
Xuanwo
approved these changes
Mar 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
when performing
list_with_recursive, if the object doesn't exist and the underlying service does not supportlist_with_recursive, we may incorrectly return the non-existent object.What changes are included in this PR?
Are there any user-facing changes?