-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(services/onedrive): add signer to utilize the refresh token #5733
Conversation
Behavior tests
I know the OneDrive behavior test is flaky. Fixing tests will take a few PRs and love. But it's also a good time to add new features:
cc @emliunix Feel free to try this branch if you find time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other changes look great—thank you!
root: String, | ||
access_token: String, | ||
client: HttpClient, | ||
pub struct OneDriveBackend { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming here needs to align with the scheme. Since our scheme is onedrive
instead of one_drive
, we must use Onedrive
instead of OneDrivew
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops, good catch. I didn't mean to change this struct name. Will push a fix.
I kept a few modules that are not "public interfaces" with OneDriveXXX
because OneDrive is the product name. If you want to keep the same convention following the schema name, please ping me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I really love this change!
Which issue does this PR close?
Closes #5653.
Part of #5677.
Part of #5702.
Rationale for this change
What changes are included in this PR?
This is a somewhat large PR. Reviewing it commit by commit is easier.
Are there any user-facing changes?
I added a few more refresh token settings for the OneDrive service. I added the documentation.