Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

services/s3: Implement List support #76

Merged
merged 3 commits into from
Mar 1, 2022
Merged

services/s3: Implement List support #76

merged 3 commits into from
Mar 1, 2022

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Mar 1, 2022

Signed-off-by: Xuanwo github@xuanwo.io

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Fix #75

Xuanwo added 2 commits March 1, 2022 15:08
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 1, 2022

The test should be improved in the future, but I think this PR is an excellent start to make ObjectStream work on s3.

Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link

@dantengsky dantengsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let' merge

@Xuanwo Xuanwo merged commit e15d0fd into main Mar 1, 2022
@Xuanwo Xuanwo deleted the s3-list branch March 1, 2022 09:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue of RFC-69 Object Stream
3 participants