Skip to content

[OPENJPA-2808] indicies are dropped in schema tool #59

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[OPENJPA-2808] indicies are dropped in schema tool #59

wants to merge 1 commit into from

Conversation

solomax
Copy link
Contributor

@solomax solomax commented Apr 5, 2020

No description provided.

@solomax solomax requested review from rmannibucau and struberg April 5, 2020 09:59
@rmannibucau
Copy link
Contributor

Hi @solomax ,

  1. is it possible to harness that with a test?
  2. wonder if it needs a flag since it can change old behavior in test suites, wdyt?

otherwise looks like an old due debt ;), thanks a lot.

@solomax
Copy link
Contributor Author

solomax commented Apr 9, 2020

Hello @rmannibucau, thanks for review

  1. Can this TestSchemaGenerator test be considered as good example?
  2. There is SchemaTool.Flags.indexes already, is it not enough?

Sorry for the long response

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rmannibucau rmannibucau Awaiting requested review from rmannibucau

@struberg struberg Awaiting requested review from struberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@solomax @rmannibucau