Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

upgrade maven-jar-plugin: fixes Reproducible Builds issue #3719

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

hboutemy
Copy link
Member

rework on #2519, in 2 steps: upgrade jar plugin first, then we'll see on removing the Git branch name configuration later

Purpose

Linked issue: close #xxx

Tests

API and Format

Documentation

@hboutemy hboutemy marked this pull request as draft July 10, 2024 04:53
@hboutemy
Copy link
Member Author

hboutemy commented Jul 10, 2024

upgrading the jar plugin works: no problem found by CI
but dropping the Git branch name (8c8afbf) makes 2 tests fail:

  • End to End Tests Flink 1.17
  • Flink CDC Tests

I'm reverting the Git branch name removal: let's merge the good first step, that will solve one key prerequisite for full Reproducible Builds (sources-jar reproducibility should be ok, for example, but not yet normal jar files, that have the branch name in META-INF/MANIFEST)

@hboutemy hboutemy marked this pull request as ready for review July 10, 2024 07:49
@JingsongLi
Copy link
Contributor

Thanks @hboutemy , +1 for merging.

@JingsongLi JingsongLi merged commit a8c1b3d into apache:master Jul 12, 2024
27 checks passed
@hboutemy hboutemy deleted the patch-1 branch July 13, 2024 08:28
hboutemy added a commit to hboutemy/incubator-paimon that referenced this pull request Sep 14, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants