Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Isolate PolarisSparkIntegrationTest #749

Closed
adutra opened this issue Jan 14, 2025 · 5 comments
Closed

Isolate PolarisSparkIntegrationTest #749

adutra opened this issue Jan 14, 2025 · 5 comments
Labels
enhancement New feature or request

Comments

@adutra
Copy link
Contributor

adutra commented Jan 14, 2025

Is your feature request related to a problem? Please describe.

This test imports a bunch of org.apache.spark.* classes and because of that, causes trouble with dependencies:

  // required for PolarisSparkIntegrationTest
  testImplementation(enforcedPlatform(libs.scala212.lang.library))
  testImplementation(enforcedPlatform(libs.scala212.lang.reflect))
  testImplementation(libs.javax.servlet.api)
  testImplementation(libs.antlr4.runtime)

The above dependences, and in particular Antlr, prevents us from using enforcedPlatform on Quarkus BOM.

Describe the solution you'd like

We need to isolate this test in its own configuration and/or module.

Describe alternatives you've considered

No response

Additional context

No response

@dimas-b
Copy link
Contributor

dimas-b commented Jan 14, 2025

PolarisSparkIntegrationTest is already in a dedicated module (integration-tests). Perhaps if we converted its execution to use @QuarkusIntegrationTest, the class path issues would be resolved (no ClassLoader sharing between tests and servers)?

@adutra
Copy link
Contributor Author

adutra commented Jan 15, 2025

PolarisSparkIntegrationTest is already in a dedicated module (integration-tests). Perhaps if we converted its execution to use @QuarkusIntegrationTest, the class path issues would be resolved (no ClassLoader sharing between tests and servers)?

I think we would still have the dependency version mismatch issue, and Antlr would have to stay pinned to 4.9.3, which isn't great.

@snazy
Copy link
Member

snazy commented Jan 15, 2025

Could also use #785 to start a "real" Polaris server and run the tests against that one.

@snazy snazy moved this to Backlog in Basic Kanban Board Feb 21, 2025
@snazy
Copy link
Member

snazy commented Mar 19, 2025

@adutra I think we're good now?

@adutra
Copy link
Contributor Author

adutra commented Mar 19, 2025

Indeed, fixed by #1109. Closing.

@adutra adutra closed this as completed Mar 19, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Basic Kanban Board Mar 19, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants