-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Move QuarkusSparkIT to a separate module #1109
Conversation
b1ea131
to
e0a36fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change LGTM. The suggested change in the base tests module can be a follow-up PR (if we want to do that)
testFixturesApi(project(":polaris-tests")) | ||
testFixturesApi(project(":polaris-tests")) { | ||
// exclude all spark dependencies | ||
exclude(group = "org.apache.iceberg", module = "iceberg-spark-3.5_2.12") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to split polaris-tests
into a general part (that only uses Iceberg Core) and a Spark-specific part (instead of excluding spark jars)?
Can we add |
The idea behind the
TBH, I do not see how it fits inside the |
Are we trying to support a Polaris server not powered by Quarkus? I'd assume not. In that case, the chances of reuse |
I mean any downstream build of Polaris. The |
That would still be rare, as people need to rewrite a lot of code to bring it up with a non-Quarkus server. I am wondering how it could happen. |
I mean running a custom server outside the Quarkus Integration Test framework. The server itself may very well be based on Quarkus, but running in docker, for example. |
e0a36fb
to
4488eef
Compare
@flyrain are you OK merging this? |
yeah, feel free to do so. |
The Spark integration tests require specific versions of some dependencies that conflicting more and more with the versions declared in the Quarkus BOM.
This PR simply isolates
QuarkusSparkIT
in its own module in order to alleviate the amount of tweaks we need to do inpolaris-quarkus-service
to get it to build correctly.