Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Issues/23555 #57

Merged
merged 7 commits into from
Nov 14, 2024
Merged

Issues/23555 #57

merged 7 commits into from
Nov 14, 2024

Conversation

visxu
Copy link
Contributor

@visxu visxu commented Nov 10, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #apache/pulsar#23555

Motivation

Release Pulsar-adapters to support Pulsar3.0.7

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

  1. Upgrade Pulsar dependency version to 3.0.7
  2. Change import package path, replace deprecated method
  3. Require JDK17

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (don't know)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Upgrade Pulsar to 3.0.7
- Use `jdk17`
- Upgrade `maven-shade-plugin` to support `jdk17`
@nodece nodece self-requested a review November 12, 2024 03:08
- Remove useless property
@nodece nodece merged commit 4092d48 into apache:master Nov 14, 2024
2 checks passed
@nodece nodece added this to the 3.0.7 milestone Nov 14, 2024
@visxu visxu deleted the issues/23555 branch November 19, 2024 13:52
AnuragReddy2000 pushed a commit to AnuragReddy2000/pulsar-adapters that referenced this pull request Jan 29, 2025
* Fix issue: apache/pulsar#23555.
Upgrade Pulsar to 3.0.7

* Fix issue: apache/pulsar#23555.
- Use `jdk17`
- Upgrade `maven-shade-plugin` to support `jdk17`

* Fix issue: apache/pulsar#23555.
- Fix UT

* Fix issue: apache/pulsar#23555.
- Fix UT

* Fix issue: apache/pulsar#23555.
- remove useless variable

* Fix issue: apache/pulsar#23555.
- Use jdk8

* Fix issue: apache/pulsar#23555.
- Remove useless property
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants