fix pulsar admin revoke subscription permission endpoint #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test for this PR? |
i see |
nodece
approved these changes
Jul 19, 2024
RobertIndie
pushed a commit
that referenced
this pull request
Jul 31, 2024
* fix pulsar admin revoke subscription permission endpoint * feat: support get subscription permissions and add test case * feat: remove fmt package --------- Co-authored-by: haotao chen <haotao.chen@shopee.com> (cherry picked from commit df6a15c)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The endpoint of RevokeSubPermission does't contain
subscriptionwrong endpoint: /{property}/{namespace}/permissions/subscription/{subscription}/{role}
correct endpoint: /{property}/{namespace}/permissions/{subscription}/{role}
https://github.com/apache/pulsar/blob/88ebe785dbdab239104981453a9bd0e4a7e896d3/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java#L366
Modifications
delete subscription