exception: replace 'BrokerPersistentException' with 'UnKnownException'

apache · Dec 11, 2023 · 501feb5 · 501feb5
1 parent 64412a0
commit 501feb5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
@@ -2123,7 +2123,7 @@ protected void handleGetLastMessageId(CommandGetLastMessageId getLastMessageId)
                         consumer.getSubscription().getName());
             }).exceptionally(e -> {
                 writeAndFlush(Commands.newError(getLastMessageId.getRequestId(),
-                        ServerError.PersistenceError, "Failed to recover Transaction Buffer."));
+                        ServerError.UnknownError, "Failed to recover Transaction Buffer."));
                 return null;
             });
         } else {

diff --git a/...src/test/java/org/apache/pulsar/broker/transaction/buffer/TopicTransactionBufferTest.java b/...src/test/java/org/apache/pulsar/broker/transaction/buffer/TopicTransactionBufferTest.java
@@ -22,6 +22,7 @@
 import static org.mockito.ArgumentMatchers.anyBoolean;
 import static org.mockito.Mockito.when;
 import static org.testng.AssertJUnit.assertEquals;
+import static org.testng.AssertJUnit.assertTrue;
 import static org.testng.AssertJUnit.fail;
 import java.util.List;
 import lombok.Cleanup;
@@ -236,7 +237,8 @@ public void testGetMaxPositionAfterTBReady() throws Exception {
         try {
             consumer.getLastMessageIds();
             fail();
-        } catch (PulsarClientException.BrokerPersistenceException ignore) {
+        } catch (PulsarClientException exception) {
+            assertTrue(exception.getMessage().contains("Failed to recover Transaction Buffer."));
         }
         List<TopicMessageId> messageIdList = consumer.getLastMessageIds();
         assertEquals(messageIdList.size(), 1);