[improve][build] Improve docker-push (#22702)

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
apache · May 13, 2024 · 9668674 · 9668674
1 parent 9fd1b61
commit 9668674
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 38 deletions.
diff --git a/docker/pulsar-all/pom.xml b/docker/pulsar-all/pom.xml
@@ -146,6 +146,7 @@
                 <goals>
                   <goal>build</goal>
                   <goal>tag</goal>
+                  <goal>push</goal>
                 </goals>
                 <configuration>
                   <images>
@@ -180,25 +181,9 @@
 
     <profile>
       <id>docker-push</id>
-      <build>
-        <plugins>
-          <plugin>
-            <groupId>io.fabric8</groupId>
-            <artifactId>docker-maven-plugin</artifactId>
-            <executions>
-              <execution>
-                <id>default</id>
-                <phase>package</phase>
-                <goals>
-                  <goal>build</goal>
-                  <goal>tag</goal>
-                  <goal>push</goal>
-                </goals>
-              </execution>
-            </executions>
-          </plugin>
-        </plugins>
-      </build>
+      <properties>
+        <docker.skip.push>false</docker.skip.push>
+      </properties>
     </profile>
 
   </profiles>

diff --git a/docker/pulsar/pom.xml b/docker/pulsar/pom.xml
@@ -73,6 +73,7 @@
                 <goals>
                   <goal>build</goal>
                   <goal>tag</goal>
+                  <goal>push</goal>
                 </goals>
                 <configuration>
                   <images>
@@ -124,25 +125,9 @@
 
     <profile>
       <id>docker-push</id>
-      <build>
-        <plugins>
-          <plugin>
-            <groupId>io.fabric8</groupId>
-            <artifactId>docker-maven-plugin</artifactId>
-            <executions>
-              <execution>
-                <id>default</id>
-                <phase>package</phase>
-                <goals>
-                  <goal>build</goal>
-                  <goal>tag</goal>
-                  <goal>push</goal>
-                </goals>
-              </execution>
-            </executions>
-          </plugin>
-        </plugins>
-      </build>
+      <properties>
+        <docker.skip.push>false</docker.skip.push>
+      </properties>
     </profile>
 
   </profiles>

diff --git a/pom.xml b/pom.xml
@@ -103,6 +103,7 @@ flexible messaging model and an intuitive client API.</description>
          To create multi-arch image, pass -Ddocker.platforms=linux/arm64,linux/amd64
     -->
     <docker.platforms></docker.platforms>
+    <docker.skip.push>true</docker.skip.push>
 
     <!-- required for running tests on JDK11+ -->
     <test.additional.args>