Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Bug] validatePoliciesReadOnlyAccessAsync is missing from internalRevokePermissionsOnTopic #23715

Closed
2 of 3 tasks
lhotari opened this issue Dec 11, 2024 · 1 comment · Fixed by #23730
Closed
2 of 3 tasks

[Bug] validatePoliciesReadOnlyAccessAsync is missing from internalRevokePermissionsOnTopic #23715

lhotari opened this issue Dec 11, 2024 · 1 comment · Fixed by #23730
Labels
type/bug The PR fixed a bug or issue reported a bug

Comments

@lhotari
Copy link
Member

lhotari commented Dec 11, 2024

Search before asking

  • I searched in the issues and found nothing similar.

Read release policy

  • I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.

Version

after 62c6f08 / PR #20478

Minimal reproduce step

validatePoliciesReadOnlyAccessAsync is missing from internalRevokePermissionsOnTopic

What did you expect to see?

validatePoliciesReadOnlyAccessAsync to be called like it's the case for internalGrantPermissionsOnTopic

What did you see instead?

The method call is missing

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@lhotari lhotari added the type/bug The PR fixed a bug or issue reported a bug label Dec 11, 2024
@lhotari
Copy link
Member Author

lhotari commented Dec 11, 2024

@Technoboy- Do you have a chance to handle this?

@dao-jun dao-jun mentioned this issue Dec 13, 2024
Merged
15 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix][admin] Verify is policies read only before revoke permissions on topic dao-jun/pulsar
1 participant
@lhotari