-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[fix][admin] Verify is policies read only before revoke permissions on topic #23730
Merged
Technoboy-
merged 2 commits into
apache:master
from
dao-jun:fix/verify_policies-readonly-before-revoke-permission-on-topic
Dec 17, 2024
Merged
[fix][admin] Verify is policies read only before revoke permissions on topic #23730
Technoboy-
merged 2 commits into
apache:master
from
dao-jun:fix/verify_policies-readonly-before-revoke-permission-on-topic
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @dao-jun. Could we add tests to cover this? The lack of tests made it possible that this regression happened in the first place. |
Technoboy-
reviewed
Dec 16, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
@lhotari @Technoboy- PTAL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23730 +/- ##
============================================
+ Coverage 73.57% 74.37% +0.80%
- Complexity 32624 34568 +1944
============================================
Files 1877 1945 +68
Lines 139502 147511 +8009
Branches 15299 16280 +981
============================================
+ Hits 102638 109712 +7074
- Misses 28908 29327 +419
- Partials 7956 8472 +516
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Dec 17, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
area/admin
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.8
release/4.0.2
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23715
Motivation
see #23715
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete