Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[fix][admin] Verify is policies read only before revoke permissions on topic #23730

Conversation

dao-jun
Copy link
Member

@dao-jun dao-jun commented Dec 13, 2024

Fixes #23715

Motivation

see #23715

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@dao-jun dao-jun self-assigned this Dec 13, 2024
@dao-jun dao-jun added area/admin type/bug The PR fixed a bug or issue reported a bug labels Dec 13, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 13, 2024
@dao-jun dao-jun added release/4.0.2 release/3.0.8 and removed doc-not-needed Your PR changes do not impact docs labels Dec 13, 2024
@dao-jun dao-jun added this to the 4.1.0 milestone Dec 13, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 13, 2024
@lhotari
Copy link
Member

lhotari commented Dec 13, 2024

Thanks @dao-jun. Could we add tests to cover this? The lack of tests made it possible that this regression happened in the first place.

@dao-jun
Copy link
Member Author

dao-jun commented Dec 16, 2024

@lhotari @Technoboy- PTAL

@dao-jun dao-jun closed this Dec 16, 2024
@dao-jun dao-jun reopened this Dec 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.37%. Comparing base (bbc6224) to head (4699840).
Report is 794 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23730      +/-   ##
============================================
+ Coverage     73.57%   74.37%   +0.80%     
- Complexity    32624    34568    +1944     
============================================
  Files          1877     1945      +68     
  Lines        139502   147511    +8009     
  Branches      15299    16280     +981     
============================================
+ Hits         102638   109712    +7074     
- Misses        28908    29327     +419     
- Partials       7956     8472     +516     
Flag Coverage Δ
inttests 27.40% <0.00%> (+2.82%) ⬆️
systests 24.37% <0.00%> (+0.05%) ⬆️
unittests 73.77% <100.00%> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pulsar/broker/admin/impl/PersistentTopicsBase.java 69.74% <100.00%> (+4.28%) ⬆️

... and 676 files with indirect coverage changes

@Technoboy- Technoboy- merged commit 069cc3d into apache:master Dec 17, 2024
73 of 76 checks passed
@dao-jun dao-jun deleted the fix/verify_policies-readonly-before-revoke-permission-on-topic branch December 17, 2024 07:54
lhotari pushed a commit that referenced this pull request Dec 17, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] validatePoliciesReadOnlyAccessAsync is missing from internalRevokePermissionsOnTopic
4 participants