Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[improve][broker] PIP-275:Introduce topicOrderedExecutorThreadNum to deprecate numWorkerThreadsForNonPersistentTopic #20504

Conversation

AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Jun 6, 2023

PIP: #20507

Motivation

See #20507

Modifications

Introduce topicOrderedExecutorThreadNum to deprecate numWorkerThreadsForNonPersistentTopic

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: AnonHxy#41

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 6, 2023
@AnonHxy AnonHxy changed the title Introduce numWorkerThreadsForPersistentTopic to deprecate numWorkerThreadsForNonPersistentTopic [improve][broker] Introduce numWorkerThreadsForPersistentTopic to deprecate numWorkerThreadsForNonPersistentTopic Jun 6, 2023
@AnonHxy AnonHxy changed the title [improve][broker] Introduce numWorkerThreadsForPersistentTopic to deprecate numWorkerThreadsForNonPersistentTopic [improve][broker] Introduce numWorkersTopicOrderedExecutor to deprecate numWorkerThreadsForNonPersistentTopic Jun 8, 2023
@AnonHxy AnonHxy force-pushed the deprecated_numWorkerThreadsForNonPersistentTopic branch from 2816e45 to 61e22cb Compare June 12, 2023 11:16
@AnonHxy AnonHxy changed the title [improve][broker] Introduce numWorkersTopicOrderedExecutor to deprecate numWorkerThreadsForNonPersistentTopic [improve][broker] PIP-275:Introduce numWorkersTopicOrderedExecutor to deprecate numWorkerThreadsForNonPersistentTopic Jun 12, 2023
@AnonHxy AnonHxy changed the title [improve][broker] PIP-275:Introduce numWorkersTopicOrderedExecutor to deprecate numWorkerThreadsForNonPersistentTopic [improve][broker] PIP-275:Introduce topicOrderedExecutorThreadNum to deprecate numWorkerThreadsForNonPersistentTopic Jun 21, 2023
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Jun 21, 2023

/pulsarbot run-failure-checks

@AnonHxy AnonHxy self-assigned this Jun 21, 2023
@AnonHxy AnonHxy force-pushed the deprecated_numWorkerThreadsForNonPersistentTopic branch from ad67762 to d3f9784 Compare June 22, 2023 03:00
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Jun 24, 2023

Copy link
Contributor

@HQebupt HQebupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@congbobo184 congbobo184 merged commit 2b01f83 into apache:master Jun 25, 2023
@congbobo184 congbobo184 added this to the 3.1.0 milestone Jun 25, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/broker doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants