[fix][broker] Fix issue with consumer read uncommitted messages from compacted topic #21465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
requested review from
liangyepianzhou,
gaoran10 and
codelipenghui
and removed request for
liangyepianzhou
poorbarcode
approved these changes
Oct 31, 2023
coderzc
changed the title
| Transaction txn = pulsarClient.newTransaction() | ||
| .withTransactionTimeout(1, TimeUnit.MINUTES).build().get(); | ||
| producer.newMessage(txn).key("K2").value("V2").send(); | ||
| producer.newMessage(txn).key("K3").value("V3").send(); |
There was a problem hiding this comment.
Should we send some messages with the same key?
There was a problem hiding this comment.
It shouldn't be necessary, we just need to enable readCompacted for consumers then consumers will read messages from the compacted topic although the compaction task may not have run yet.
liangyepianzhou
approved these changes
Nov 3, 2023
codelipenghui
approved these changes
Nov 3, 2023
|
@coderzc I think this PR should not be cherry-picked to release branches because the API of |
Oh, we can cherry-pick it to release branches through add new asyncReadCompactedEntries. |
Technoboy-
added
cherry-picked/branch-3.1
release/3.0.3
and removed
release/3.0.2
labels
coderzc
added a commit
to coderzc/pulsar
that referenced
this pull request
Nov 13, 2023
…compacted topic (apache#21465) (cherry picked from commit b5925ed)
4 tasks
nborisov
pushed a commit
to nborisov/pulsar
that referenced
this pull request
Nov 13, 2023
coderzc
added a commit
to coderzc/pulsar
that referenced
this pull request
Nov 20, 2023
…compacted topic (apache#21465) (cherry picked from commit b5925ed)
coderzc
added a commit
to coderzc/pulsar
that referenced
this pull request
Nov 21, 2023
…compacted topic (apache#21465) (cherry picked from commit b5925ed)
|
Cherry-picked by #21570 |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
…es from compacted topic (apache#21465)" This reverts commit 80f921a.
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
…ssages from compacted topic (apache#21465) (apache#21571)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
…es from compacted topic (apache#21465)" This reverts commit 80f921a.
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
…ssages from compacted topic (apache#21465) (apache#21571)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2024
…es from compacted topic (apache#21465)" This reverts commit 80f921a. (cherry picked from commit c616deb)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2024
…ssages from compacted topic (apache#21465) (apache#21571) (cherry picked from commit a303bd1)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
…es from compacted topic (apache#21465)" This reverts commit 80f921a. (cherry picked from commit c616deb)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
…ssages from compacted topic (apache#21465) (apache#21571) (cherry picked from commit a303bd1)
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21464
Motivation
The consumer shouldn't read ongoing messages from compacted topic.
Modifications
Pass
topic.getMaxReadPosition()to cursor when reading messages from the compacted topic.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: