Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[fix][client] Fix ConsumerStats.getRateMsgsReceived javadoc #21618

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

ahscuml
Copy link
Contributor

@ahscuml ahscuml commented Nov 24, 2023

  • [doc] easy doc fix

  • doc

  • doc-required

  • doc-not-needed

  • doc-complete

Copy link

@ahscuml Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@Technoboy- Technoboy- added this to the 3.3.0 milestone Dec 22, 2023
@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
@lhotari lhotari modified the milestones: 4.0.0, 4.1.0 Oct 11, 2024
@lhotari lhotari changed the title [fix]<client-api>: easy doc fix [fix][client] Fix ConsumerStats.getRateMsgsReceived javadoc Oct 14, 2024
@github-actions github-actions bot added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-label-missing labels Oct 14, 2024
@lhotari lhotari closed this Oct 14, 2024
@lhotari lhotari reopened this Oct 14, 2024
@lhotari lhotari added the triage/lhotari/important lhotari's triaging label for important issues or PRs label Oct 14, 2024
@lhotari lhotari closed this Oct 16, 2024
@lhotari lhotari reopened this Oct 16, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.26%. Comparing base (2a5aa44) to head (ad72fce).
Report is 890 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21618       +/-   ##
=============================================
+ Coverage     36.73%   74.26%   +37.53%     
- Complexity    12195    34383    +22188     
=============================================
  Files          1715     1943      +228     
  Lines        131087   146973    +15886     
  Branches      14317    16191     +1874     
=============================================
+ Hits          48155   109155    +61000     
+ Misses        76543    29381    -47162     
- Partials       6389     8437     +2048     
Flag Coverage Δ
inttests 27.32% <ø> (+3.12%) ⬆️
systests 24.43% <ø> (-0.58%) ⬇️
unittests 73.62% <ø> (+41.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...va/org/apache/pulsar/client/api/ConsumerStats.java 0.00% <ø> (ø)

... and 1644 files with indirect coverage changes

@lhotari lhotari merged commit 842f0ce into apache:master Oct 17, 2024
76 of 80 checks passed
lhotari pushed a commit that referenced this pull request Oct 22, 2024
Co-authored-by: leoyxli <leoyxli@tencent.com>
(cherry picked from commit 842f0ce)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cherry-picked/branch-4.0 doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. release/4.0.1 triage/lhotari/important lhotari's triaging label for important issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants