Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[improve][broker] defer the ownership checks if the owner is inactive (ExtensibleLoadManager) #21857

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

heesung-sn
Copy link
Contributor

@heesung-sn heesung-sn commented Jan 5, 2024

Cherry-picked #21811

Documentation

  • doc-not-needed

Copy link

github-actions bot commented Jan 5, 2024

@heesung-sn Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@Technoboy- Technoboy- added release/3.1.3 doc-not-needed Your PR changes do not impact docs ready-to-test and removed doc-label-missing labels Jan 5, 2024
@Technoboy- Technoboy- closed this Jan 5, 2024
@github-actions github-actions bot removed the doc-not-needed Your PR changes do not impact docs label Jan 5, 2024
@Technoboy- Technoboy- reopened this Jan 5, 2024
@Technoboy- Technoboy- added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jan 5, 2024
@heesung-sn
Copy link
Contributor Author

Seems like this test is consistently failing, although it should not be related to this PR.

GitHub
Actions
/ CI - Unit - Other
ManagedLedgerTest.testNoCleanupOffloadLedgerWhenMetadataExceptionHappens
CompletableFuture cannot be returned by getPassword()
getPassword() should return byte[]
***
If you're unsure why you're getting above error read on.
Due to the nature of the syntax above problem might occur because:
1. This exception *might* occur in wrongly written multi-threaded tests.
   Please refer to Mockito FAQ on limitations of concurrency testing.
2. A spy is stubbed using when(spy.foo()).then() syntax. It is safer to stub spies - 
   - with doReturn|Throw() family of methods. More in javadocs for Mockito.spy() method.
   - ```

@Technoboy- Technoboy- merged commit b41013b into apache:branch-3.0 Jan 8, 2024
94 of 103 checks passed
@heesung-sn heesung-sn deleted the branch-3.0-cherry-pick branch February 27, 2024 18:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants