Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[improve][broker] Cache the internal writer when sent to system topic. #22099

Merged
merged 4 commits into from
Feb 24, 2024

Conversation

Technoboy-
Copy link
Contributor

Fixes #22087

Motivation

Cache the internal writer when sent to system topic.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Technoboy- Technoboy- self-assigned this Feb 22, 2024
@Technoboy- Technoboy- added this to the 3.3.0 milestone Feb 22, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 22, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 22, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.55%. Comparing base (861618a) to head (73c91be).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #22099       +/-   ##
=============================================
+ Coverage     36.89%   73.55%   +36.65%     
- Complexity    12135    32578    +20443     
=============================================
  Files          1734     1874      +140     
  Lines        132201   139360     +7159     
  Branches      14466    15278      +812     
=============================================
+ Hits          48782   102504    +53722     
+ Misses        76912    28927    -47985     
- Partials       6507     7929     +1422     
Flag Coverage Δ
inttests 24.58% <56.52%> (-0.18%) ⬇️
systests 24.25% <65.21%> (-0.10%) ⬇️
unittests 72.82% <91.30%> (+40.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...roker/systopic/TopicPoliciesSystemTopicClient.java 72.15% <100.00%> (+16.30%) ⬆️
.../service/SystemTopicBasedTopicPoliciesService.java 73.69% <89.47%> (+20.19%) ⬆️

... and 1442 files with indirect coverage changes

heesung-sn pushed a commit that referenced this pull request Feb 27, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 1, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[improve] Reuse the internal writer/reader under the same system topic
7 participants