-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[improve][broker] Cache the internal writer when sent to system topic. #22099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
reviewed
Feb 23, 2024
...ker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
Outdated
Show resolved
Hide resolved
merlimat
reviewed
Feb 23, 2024
...ker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
Show resolved
Hide resolved
...ker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
Show resolved
Hide resolved
gaoran10
reviewed
Feb 23, 2024
...ker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22099 +/- ##
=============================================
+ Coverage 36.89% 73.55% +36.65%
- Complexity 12135 32578 +20443
=============================================
Files 1734 1874 +140
Lines 132201 139360 +7159
Branches 14466 15278 +812
=============================================
+ Hits 48782 102504 +53722
+ Misses 76912 28927 -47985
- Partials 6507 7929 +1422
Flags with carried forward coverage won't be shown. Click here to find out more.
|
160dec0
to
08afc23
Compare
dao-jun
approved these changes
Feb 23, 2024
merlimat
approved these changes
Feb 24, 2024
Technoboy-
added a commit
that referenced
this pull request
Feb 26, 2024
Technoboy-
added a commit
that referenced
this pull request
Feb 27, 2024
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2024
apache#22099) (cherry picked from commit 6e8ad69)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
apache#22099) (cherry picked from commit 6e8ad69)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
area/broker
cherry-picked/branch-3.0
cherry-picked/branch-3.1
cherry-picked/branch-3.2
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.3
release/3.1.3
release/3.2.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22087
Motivation
Cache the internal writer when sent to system topic.
Documentation
doc
doc-required
doc-not-needed
doc-complete