-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[fix][test] Fix test testAsyncFunctionMaxPending #22121
Merged
Technoboy-
merged 1 commit into
apache:master
from
liangyepianzhou:flaky/testAsyncFunctionMaxPending
Feb 27, 2024
Merged
[fix][test] Fix test testAsyncFunctionMaxPending #22121
Technoboy-
merged 1 commit into
apache:master
from
liangyepianzhou:flaky/testAsyncFunctionMaxPending
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ping @freeznet @jiangpengcheng help review |
jiangpengcheng
approved these changes
Feb 27, 2024
freeznet
approved these changes
Feb 27, 2024
heesung-sn
pushed a commit
that referenced
this pull request
Feb 27, 2024
(cherry picked from commit 91de98a)
Technoboy-
pushed a commit
that referenced
this pull request
Feb 29, 2024
gaoran10
pushed a commit
to gaoran10/pulsar
that referenced
this pull request
Mar 4, 2024
(cherry picked from commit 91de98a)
gaoran10
pushed a commit
that referenced
this pull request
Mar 4, 2024
(cherry picked from commit 91de98a)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The assert
Assert.assertEquals(request.getProcessResult().get(), testString + "-lambda");
will wait for the function process completely, so the following ones are also processed completely. And the pending requests will be removed. Which will cause an NPE when doing the next verify.Modifications
Use CountDownLatch to replace sleep and cache requests before
count.countDown();
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: