-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[fix][broker] Fix invalid condition in logging exceptions #22412
Merged
lhotari
merged 1 commit into
apache:master
from
teet-vaher-sympower:fix/remove_faulty_excl_marks
Apr 3, 2024
Merged
[fix][broker] Fix invalid condition in logging exceptions #22412
lhotari
merged 1 commit into
apache:master
from
teet-vaher-sympower:fix/remove_faulty_excl_marks
Apr 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riable isNot307And404Exception
@teet-vaher-sympower Please add the following content to your PR description and select a checkbox:
|
Great discovery. Thanks for the contribution @teet-vaher-sympower ! |
lhotari
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
poorbarcode
approved these changes
Apr 3, 2024
dao-jun
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
lhotari
pushed a commit
that referenced
this pull request
Apr 3, 2024
(cherry picked from commit cd6f53b)
lhotari
pushed a commit
that referenced
this pull request
Apr 3, 2024
(cherry picked from commit cd6f53b)
lhotari
pushed a commit
that referenced
this pull request
Apr 3, 2024
(cherry picked from commit cd6f53b)
lhotari
pushed a commit
that referenced
this pull request
Apr 3, 2024
(cherry picked from commit cd6f53b)
lhotari
pushed a commit
that referenced
this pull request
Apr 3, 2024
(cherry picked from commit cd6f53b)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 13, 2024
(cherry picked from commit cd6f53b)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
cherry-picked/branch-2.10
cherry-picked/branch-2.11
cherry-picked/branch-3.0
cherry-picked/branch-3.1
cherry-picked/branch-3.2
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.10.7
release/2.11.5
release/3.0.5
release/3.1.4
release/3.2.3
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22409
Motivation
If Admin API request is sent to the broker and it responds with 307-redirect (for example in case of the bundle is not served by this broker) then ERROR is written into the broker log file. And there are quite a lot of these errors.
broker log:
Modifications
Issue #21995 introduced a new variable
isNot307And404Exception
. Previous code was substituted with the new variable in multiple places, but the exclamation mark in front of the variable (part of the previous code) was not removed. This PR removes the remaining unnecessary exclamation marks.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: teet-vaher-sympower#1