-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[fix][broker] Support OIDC providers with JWK without alg field set in keys #22421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22421 +/- ##
============================================
+ Coverage 73.57% 73.73% +0.16%
+ Complexity 32624 32402 -222
============================================
Files 1877 1885 +8
Lines 139502 139881 +379
Branches 15299 15321 +22
============================================
+ Hits 102638 103146 +508
+ Misses 28908 28759 -149
- Partials 7956 7976 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 15, 2024
…n keys (apache#22421) (cherry picked from commit a1970ae) (cherry picked from commit 4a79a26)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…n keys (apache#22421) (cherry picked from commit a1970ae) (cherry picked from commit 4a79a26)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…n keys (apache#22421) (cherry picked from commit a1970ae) (cherry picked from commit 4a79a26)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 19, 2024
…n keys (apache#22421) (cherry picked from commit a1970ae) (cherry picked from commit 4a79a26)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2024
…n keys (apache#22421) (cherry picked from commit a1970ae) (cherry picked from commit 4a79a26)
3 tasks
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
area/authn
cherry-picked/branch-3.0
cherry-picked/branch-3.2
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.5
release/3.2.3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22419
Motivation
See #22419. "alg" field is optional in JWK spec.
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete