[admin][broker] Fix force delete subscription not working

[dao-jun]

Fixes #22404

Motivation

Fix force delete subscription not working on persistent topics.

Modifications

Verifying this change

• Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added integration tests for end-to-end deployment with large payloads (10MB)
• Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[lhotari]

LGTM

[fecet]

I still have the same issue with #22404 and #9477 on pulsar 3.3.1 on apachepulsar/pulsar-all:3.3.1

[Nowadays]

Adding to what @fecet said, the Javadoc is clearly misleading, be it on close() or unsubscribe(), which both, clearly state that with the force flag it closes both the producers and consumers connected to said topic. (pulsar-client 3.2.2, broker 3.3.2)

Which is does not since if there is a consumer connected, the topic and subscription get auto-recreated, and unfortunately we cannot disable the auto-creation through the broker.conf since we need it for another use case.