-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[fix][test] Flaky-test: ManagedLedgerTest.testTimestampOnWorkingLedger #22600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Apr 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22600 +/- ##
============================================
+ Coverage 73.57% 73.92% +0.34%
+ Complexity 32624 32606 -18
============================================
Files 1877 1885 +8
Lines 139502 140524 +1022
Branches 15299 15452 +153
============================================
+ Hits 102638 103877 +1239
+ Misses 28908 28600 -308
- Partials 7956 8047 +91
Flags with carried forward coverage won't be shown. Click here to find out more. |
Technoboy-
reviewed
Apr 26, 2024
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java
Show resolved
Hide resolved
Technoboy-
approved these changes
Apr 26, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 13, 2024
apache#22600) (cherry picked from commit 5d9ccd4) (cherry picked from commit bfdbd20)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2024
apache#22600) (cherry picked from commit 5d9ccd4) (cherry picked from commit bfdbd20)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.1
cherry-picked/branch-3.2
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.5
release/3.1.4
release/3.2.3
type/flaky-tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#22430
After #22034, When the ledger is closed due to full entry, will trigger create a new ledger, However, since the creation of the ledger is asynchronous, sometimes the last ledger is not created before the function returns.
pulsar/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
Lines 1775 to 1778 in 57a616e
For this test:
ml.close();
is no make sure that thecurrentLedger
switch successful, and there are two possible case:Case 1 will cause the test to fail.
Modifications
When
ml.close
to reopen a newManagerLedger
that will make sure intoCase1
, and then to assert timestamp ofLedger02
than 0.Verifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: