Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[fix][admin][part-2]Clearly define REST API on Open API for Namespaces@v2 #22775

Merged
merged 1 commit into from
May 27, 2024

Conversation

shibd
Copy link
Member

@shibd shibd commented May 24, 2024

Motivation

#22770

Modifications

  • Clearly define REST API on Open API for Namesaces@v2

Verifying this change

  • Local validation confirmed that the generated swagger.json file displays well on the web page.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@shibd shibd self-assigned this May 24, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.15%. Comparing base (bbc6224) to head (333104c).
Report is 603 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22775      +/-   ##
============================================
- Coverage     73.57%   73.15%   -0.42%     
- Complexity    32624    32887     +263     
============================================
  Files          1877     1890      +13     
  Lines        139502   141492    +1990     
  Branches      15299    15526     +227     
============================================
+ Hits         102638   103515     +877     
- Misses        28908    29975    +1067     
- Partials       7956     8002      +46     
Flag Coverage Δ
inttests 27.17% <ø> (+2.59%) ⬆️
systests 24.60% <ø> (+0.28%) ⬆️
unittests 72.18% <ø> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pache/pulsar/broker/admin/impl/NamespacesBase.java 76.55% <ø> (+3.47%) ⬆️
.../org/apache/pulsar/broker/admin/v2/Namespaces.java 91.54% <ø> (+22.44%) ⬆️

... and 349 files with indirect coverage changes

@Technoboy- Technoboy- added this to the 3.4.0 milestone May 25, 2024
@Technoboy- Technoboy- merged commit 9b3876d into apache:master May 27, 2024
53 of 55 checks passed
shibd added a commit that referenced this pull request May 28, 2024
shibd added a commit that referenced this pull request May 28, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request May 31, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 4, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 4, 2024
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 7, 2024
@lhotari lhotari changed the title [fix][admin][part-2]Clearly define REST API on Open API for Namesaces@v2 [fix][admin][part-2]Clearly define REST API on Open API for Namespaces@v2 Oct 14, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants