Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[fix] JWT CLI util should force the token validation #22831

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Jun 3, 2024

Motivation

The CLI tool that can be used to generate and sign tokens, should force the validation of token in the validate subcommand.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@merlimat merlimat added this to the 3.4.0 milestone Jun 3, 2024
@merlimat merlimat self-assigned this Jun 3, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 3, 2024
@merlimat merlimat merged commit 2532fbd into apache:master Jun 4, 2024
53 of 55 checks passed
@merlimat merlimat deleted the jwt-cli-validate branch June 4, 2024 04:01
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants