Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[fix][meta] Check if metadata store is closed in RocksdbMetadataStore #22852

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jun 5, 2024

Fixes #19250

Motivation

Accessing a closed RocksDb database will crash the JVM. See #19250

Modifications

  • Check if the metadata store is closed after acquiring the read lock.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.4.0 milestone Jun 5, 2024
@lhotari lhotari self-assigned this Jun 5, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 5, 2024
@lhotari lhotari changed the title [fix][metadata] Check if metadata store is closed in RocksdbMetadataStore [fix][meta] Check if metadata store is closed in RocksdbMetadataStore Jun 5, 2024
Copy link
Member

@dao-jun dao-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lhotari lhotari merged commit 7419287 into apache:master Jun 5, 2024
52 of 56 checks passed
lhotari added a commit that referenced this pull request Jun 6, 2024
lhotari added a commit that referenced this pull request Jun 6, 2024
lhotari added a commit that referenced this pull request Jun 6, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 7, 2024
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Pulsar RocksDB metadata driver causes JVM to crash in unit tests
4 participants