-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[fix] [test] fix testGetMetrics in ExtensibleLoadManagerImplTest. #22864
Conversation
PTAL, thanks. @heesung-sn @Demogorgon314 |
/pulsarbot rerun-failure-checks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22864 +/- ##
============================================
- Coverage 73.57% 73.26% -0.31%
+ Complexity 32624 2511 -30113
============================================
Files 1877 1889 +12
Lines 139502 141830 +2328
Branches 15299 15563 +264
============================================
+ Hits 102638 103916 +1278
- Misses 28908 29887 +979
- Partials 7956 8027 +71
Flags with carried forward coverage won't be shown. Click here to find out more. |
I'm wondering why this failed test was not detected before? |
This is a flaky test, which can be ignored when merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this.
Fixes #22871
Motivation
As #22820 set the default value of
LoadBalancerMemoryResourceWeight
to 0, some behavior changes resulting into the failure oforg.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImplTest#testGetMetrics
.Modifications
Set the value of
LoadBalancerMemoryResourceWeight
to 1 to pass the test.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: