[fix][build] Add re2/j dependency to pulsar-common and client shading #22884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing configs - add explicit dependency to pulsar-common module - add shading configs to pulsar-client-admin-shaded, pulsar-client-all and pulsar-client-shaded - revert changes to PulsarVersion since it doesn't use user provided regex
merlimat
approved these changes
Jun 9, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #22829 changes
Motivation
I noticed that pulsar-common didn't have an explicit re2/j dependency and client shading configs were missing. I also noticed that PulsarVersion should continue to use plain
java.util.regex.Pattern.Modifications
com.google.re2j:re2jto pulsar-common modulecom.google.re2j:re2jto pulsar-client-admin-shaded, pulsar-client-all and pulsar-client-shadedDocumentation
docdoc-requireddoc-not-neededdoc-complete