Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[improve][build] Move docker-push profile to submodule #23093

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

nodece
Copy link
Member

@nodece nodece commented Jul 29, 2024

Motivation

The profile refactoring breaks the pulsar release in the #23091.

Modifications

  • Move docker-push profile to docker/pulsar and docker/pulsar-all modules

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece requested a review from lhotari July 29, 2024 15:10
@nodece nodece self-assigned this Jul 29, 2024
@nodece nodece added this to the 3.4.0 milestone Jul 29, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 29, 2024
@nodece nodece closed this Jul 29, 2024
@nodece nodece reopened this Jul 29, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.44%. Comparing base (bbc6224) to head (6022c9e).
Report is 479 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23093      +/-   ##
============================================
- Coverage     73.57%   73.44%   -0.14%     
- Complexity    32624    33524     +900     
============================================
  Files          1877     1919      +42     
  Lines        139502   144087    +4585     
  Branches      15299    15745     +446     
============================================
+ Hits         102638   105824    +3186     
- Misses        28908    30145    +1237     
- Partials       7956     8118     +162     
Flag Coverage Δ
inttests 27.58% <ø> (+2.99%) ⬆️
systests 24.76% <ø> (+0.43%) ⬆️
unittests 72.51% <ø> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 516 files with indirect coverage changes

@nodece nodece merged commit 47d35a0 into apache:master Jul 29, 2024
70 of 75 checks passed
@nodece nodece deleted the move-docker-push-profile branch July 29, 2024 17:13
nodece added a commit to ascentstream/pulsar that referenced this pull request Aug 28, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 47d35a0)
nodece added a commit to ascentstream/pulsar that referenced this pull request Oct 17, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 47d35a0)
nodece added a commit to nodece/pulsar that referenced this pull request Oct 24, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 47d35a0)
nodece added a commit that referenced this pull request Oct 29, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 47d35a0)
nodece added a commit to ascentstream/pulsar that referenced this pull request Dec 3, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 47d35a0)
nodece added a commit to ascentstream/pulsar that referenced this pull request Jan 7, 2025
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 47d35a0)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
nodece added a commit to ascentstream/pulsar that referenced this pull request Feb 13, 2025
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 47d35a0)
nodece added a commit to ascentstream/pulsar that referenced this pull request Feb 17, 2025
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 47d35a0)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/build doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants